Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support algorithm to be given as a class #512

Merged
merged 6 commits into from
Oct 9, 2022
Merged

Support algorithm to be given as a class #512

merged 6 commits into from
Oct 9, 2022

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Oct 1, 2022

This PR improves the algorithm handling on both encoding and decoding:

  • Support for passing custom algorithms to handle the signing and verification of tokens
  • When decoding the alg header is not used as anything else than a hint for the algorithm to try first from the allowed algorithms.

@anakinj anakinj mentioned this pull request Oct 4, 2022
Closed
@anakinj anakinj force-pushed the allow-algorithm-to-be-a-class branch from b8c52e2 to 6b50050 Compare October 4, 2022 19:05
@anakinj
Copy link
Member Author

anakinj commented Oct 4, 2022

Would you @excpt have time to check this out. Would enable some further improvements to be made to the signing and verification.

@anakinj anakinj requested a review from excpt October 4, 2022 19:14
MatteoPierro
MatteoPierro reviewed Oct 5, 2022
View reviewed changes
MatteoPierro
MatteoPierro reviewed Oct 5, 2022
View reviewed changes
MatteoPierro
MatteoPierro reviewed Oct 5, 2022
View reviewed changes
@anakinj anakinj requested a review from MatteoPierro October 6, 2022 18:51
MatteoPierro
MatteoPierro approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@MatteoPierro MatteoPierro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 👍

@anakinj anakinj removed the request for review from excpt October 9, 2022 08:33
@anakinj anakinj force-pushed the allow-algorithm-to-be-a-class branch from 3ee0fa1 to 752ec8b Compare October 9, 2022 11:35
@anakinj anakinj merged commit 37a0d9e into jwt:main Oct 9, 2022
@nataliastanko nataliastanko mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoPierro MatteoPierro MatteoPierro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakinj @MatteoPierro