Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on how to contribute #463

Merged
merged 1 commit into from
May 29, 2022
Merged

Conversation

anakinj
Copy link
Member

@anakinj anakinj commented Jan 3, 2022

Ref to discussion #461

Tried to write down the contribution process and how to keep the CHANGELOG up to speed at all times.

The process for releasing is a little questionmark still.

@anakinj anakinj requested a review from excpt January 3, 2022 21:38
@anakinj anakinj force-pushed the changelog-process branch 3 times, most recently from a968663 to 50f7a58 Compare January 5, 2022 10:05
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

I really like the wording and the changes to the contribution for future pull requests.

@anakinj
Copy link
Member Author

anakinj commented May 4, 2022

Great. Thanks for the feedback @excpt. I'll update the branch to reflect the changes done between the last update and now. Then i could probably merge this one.

@anakinj anakinj force-pushed the changelog-process branch from dbbd4b3 to a24c750 Compare May 29, 2022 17:07
@anakinj
Copy link
Member Author

anakinj commented May 29, 2022

@excpt I updated the changelog with the merged feature and relevant fixes. Just so you are on the clear the "Closed issues" section will be no more only fixes and features. So references to PRs only.

Are you OK with the proposed changes still? :)

@excpt excpt merged commit 69c5839 into jwt:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants