Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query type 65 is invalid #7

Closed
james-antill opened this issue Apr 1, 2021 · 14 comments · Fixed by #25
Closed

query type 65 is invalid #7

james-antill opened this issue Apr 1, 2021 · 14 comments · Fixed by #25

Comments

@james-antill
Copy link

Ran it for a while on Mac OS X, get a bunch of:

Error parsing DNS packet: Failed to parse DNS packet: query type 65 is invalid

@chrismccoy
Copy link

Ran it for a while on Mac OS X, get a bunch of:

Error parsing DNS packet: Failed to parse DNS packet: query type 65 is invalid

is this for google/youtube requests? im getting the same with google searches, and youtube video loads

@nogweii
Copy link

nogweii commented Apr 1, 2021

For some context, query type 65 is the 'HTTPSSVC' query (draft, upstream github repo)

@badnetmask
Copy link

Related: I am getting "query type 256 is invalid" in Linux. I am adding this here, because maybe the code just needs some "consolidated" way to deal with these different/unnusual types of packets.

@jvns
Copy link
Owner

jvns commented Apr 1, 2021

All of the "query type X is invalid" errors are happening because the DNS packet parsing crate dnspeep is using is very incomplete and only supports these record types. I think this isn't a great choice of crate and we should use a different one.

Some other Rust DNS code and links to the record types they support right now:

I think the best thing might to be to use dns-message-parser and then make PRs to it to get support for more query types as needed.

@badnetmask
Copy link

A quick look at dns_message_parser, yes it seems like it does support a lot more types than dns_parser. I can even see type 256 (URI), but not 65 (HTTPS), most likely because that one is still in draft.
Thanks for checking this out!
For me, no rush on the implementation. So far it's been working great for me, the other records are just icing on the cake. :)

@thomasmerz
Copy link
Contributor

BTW: On my Linux Client (OpenSUSE) I have seen also some
Error parsing DNS packet: Failed to parse DNS packet: query type 43 is invalid
🤔

@thomasmerz
Copy link
Contributor

Informational update only ℹ️

Message changed with 0.1.2 to:

timestamp      query name                           server IP            elapsed   response
Error parsing DNS packet: Failed to parse DNS packet: Could not decode QType: 65
Error parsing DNS packet: Failed to parse DNS packet: Could not decode QType: 65

@jumarko
Copy link

jumarko commented Nov 9, 2021

A variant of this issue that shows up on my computer (macOS):

Error parsing DNS packet: Failed to parse DNS packet: Could not decode QType: 65

l0s added a commit to l0s/dnspeep that referenced this issue Jan 16, 2022
This adds support for record types 64 and 65, service binding and HTTPS.
This required upgrading to the latest version of `dns-message-parser` and
bumping the minor revision of `bytes`.

Resolves: jvns#7
@jvns jvns closed this as completed in #25 Jan 17, 2022
jvns pushed a commit that referenced this issue Jan 17, 2022
This adds support for record types 64 and 65, service binding and HTTPS.
This required upgrading to the latest version of `dns-message-parser` and
bumping the minor revision of `bytes`.

Resolves: #7
@thomasmerz
Copy link
Contributor

@jvns , great, thank you very much 🎉
Can you tell me/us when we will get a new release for this and all other changes since April 2021?

@jvns
Copy link
Owner

jvns commented Jan 19, 2022

Made a new release.

@jumarko
Copy link

jumarko commented Jan 19, 2022

@jvns I've just downloaded the latest version for macos but it still produces this error

sudo dnspeep

query name                           server IP            response
Error parsing DNS packet: Failed to parse DNS packet: Could not decode QType: 65
Warning: got response for unknown query ID 11315

(This happened when I opened https://curiousprogrammer.net/ in the browser but it might be unrelated)

@thomasmerz
Copy link
Contributor

(This happened when I opened https://curiousprogrammer.net/ in the browser but it might be unrelated)

On my Macbook no error message like this are occuring anymore 👍🏻 Even if I'm opening https://curiousprogrammer.net/ in the browser.

@thomasmerz
Copy link
Contributor

But on my Linux Desktop it says that a different type is not yet implemented:

Error parsing DNS packet: Failed to parse DNS packet: Decode of type RRSIG is not yet implemented

Found an old issue from April 2020 opened by me: #19

@thomasmerz
Copy link
Contributor

Opened a new issue for "got response for unknown query ID": #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants