Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unbound type parameters #12

Merged
merged 1 commit into from
Dec 14, 2022
Merged

fix unbound type parameters #12

merged 1 commit into from
Dec 14, 2022

Conversation

nsajko
Copy link
Contributor

@nsajko nsajko commented Dec 14, 2022

I didn't check, but unbound type parameters can be serious performance bugs.

Found with JuliaLang/julia#46608

I didn't check, but unbound type parameters can be serious performance
bugs.

Found with JuliaLang/julia#46608
@jverzani
Copy link
Owner

Thanks! Most appreciated. I'll merge in once everything passes CI tests.

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #12 (c644933) into master (98688e2) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   86.91%   86.93%   +0.02%     
==========================================
  Files          19       19              
  Lines        1826     1891      +65     
==========================================
+ Hits         1587     1644      +57     
- Misses        239      247       +8     
Impacted Files Coverage Δ
src/diagonal-block.jl 97.01% <100.00%> (+0.29%) ⬆️
src/twisted.jl 87.33% <100.00%> (-0.22%) ⬇️
src/AMRVW_algorithm.jl 82.52% <0.00%> (-0.48%) ⬇️
src/rfactorization.jl 83.43% <0.00%> (-0.23%) ⬇️
src/diagonal.jl 85.89% <0.00%> (-0.14%) ⬇️
src/CSS.jl 100.00% <0.00%> (ø)
src/RDS.jl 100.00% <0.00%> (ø)
src/bulge-step.jl 100.00% <0.00%> (ø)
src/utils.jl 97.18% <0.00%> (+0.08%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jverzani
Copy link
Owner

Thanks for these. I have to address the CI test that is failing and bump the versions. Once that is done, i'll tag a new release.

@jverzani jverzani merged commit 5b12cd4 into jverzani:master Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants