Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Default custom colors #151

Closed
l3td33r opened this issue Mar 26, 2021 · 7 comments
Closed

[Enhancement] Default custom colors #151

l3td33r opened this issue Mar 26, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@l3td33r
Copy link
Contributor

l3td33r commented Mar 26, 2021

Set the default 16 colors in the color picker to some predefined values (right now they're all white), to make the workflow easier.

We can use colors from one of the popular palettes:
https://lospec.com/palette-list/island-joy-16 (I like this one, the colors are not too intense)
or https://lospec.com/palette-list/sweetie-16

Related: https://doc.qt.io/qt-5/qcolordialog.html#setCustomColor

@cantalisa
Copy link

cantalisa commented Mar 30, 2021

I agree! I think it's a good idea.

Even an option (a toolbar or a button with an ink-bottle icon or something) with default set of colors would be great (or create another one). So in one click you choose if you want it with white nodes and gray background, x-color nodes or y-color background, or so on.

Currently the toolbar is functional but something tedious if you try several colors, mainly because the selection of colors are somewhat confusing (as for custom colors) and the basic colors are somewhat strong.

@juzzlin juzzlin added the enhancement New feature or request label Mar 31, 2021
@juzzlin
Copy link
Owner

juzzlin commented Mar 31, 2021

Ok, as seems to be doable with QColorDialog.

@juzzlin
Copy link
Owner

juzzlin commented Apr 5, 2021

Seems that for example Ubuntu 20.04 shows a different and more simple color dialog than other systems. The system color dialog can be disabled, but not sure if that's an improvement.

@juzzlin
Copy link
Owner

juzzlin commented Apr 5, 2021

This is the color picker Heimer shows on Ubuntu 20.04 by default:
UbuntuPicker

@juzzlin
Copy link
Owner

juzzlin commented Apr 5, 2021

This is the Qt (I think!) color picker with custom palette:
QtPicker

@juzzlin juzzlin self-assigned this Apr 5, 2021
juzzlin added a commit that referenced this issue Apr 5, 2021
- Harmonizes color picker dialog between platforms
juzzlin added a commit that referenced this issue Apr 5, 2021
- Harmonizes color picker dialog between platforms
@juzzlin
Copy link
Owner

juzzlin commented Apr 5, 2021

Fixed in 6eb4ca2. This can be now more easily further improved. Thanks!

@juzzlin juzzlin closed this as completed Apr 5, 2021
@l3td33r
Copy link
Contributor Author

l3td33r commented Apr 5, 2021

Wow, looks cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants