Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak when changing Edge width, Text size and corner radius #106

Closed
Toshka31 opened this issue Aug 20, 2020 · 3 comments
Closed

Memory leak when changing Edge width, Text size and corner radius #106

Toshka31 opened this issue Aug 20, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Toshka31
Copy link
Contributor

I saw that application consumes more memory when changing values by arrows too often (after 1 minute of changing from 14 to 58 Mb)

@juzzlin
Copy link
Owner

juzzlin commented Aug 20, 2020

How often? That could just be the undo stack taking more memory, not a leak as such.

If that's the case then there could just be a small delay - probably.

@juzzlin juzzlin added the bug Something isn't working label Aug 20, 2020
@Toshka31
Copy link
Contributor Author

about 3 times a second.
I think that's really undo stack, but it's not ok X3 memory usage. Maybe refactor undo/redo mechanics? Not save copy of ALL parameters but zipping them or save only changed values?

juzzlin added a commit that referenced this issue Sep 1, 2020
@juzzlin juzzlin self-assigned this Sep 1, 2020
@juzzlin
Copy link
Owner

juzzlin commented Sep 1, 2020

Let's try this: be3b43b

I made it to not push every single quick change (< 500 ms) to the undo stack. There are also some other possibilities to improve this (change sets, write to disk etc), but they'd need a lot of more work to implement.

@juzzlin juzzlin closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants