Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide direct encryptor stream + some minor improvements #26

Merged
merged 6 commits into from
Feb 13, 2020

Conversation

lgoldstein
Copy link

No description provided.

Copy link
Owner

@justinludwig justinludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! -- I just have a few questions about the prepareCiphertextOutputStream(File) method, as well a few other small suggestions (inline).

@lgoldstein
Copy link
Author

Updated the PR as per your (excellent) comments.

@justinludwig justinludwig merged commit 8e29882 into justinludwig:master Feb 13, 2020
@lgoldstein lgoldstein deleted the direct-streams branch February 13, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants