Replace J-U-L with slf4j #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,8 +229,8 @@ public FileMetadata decrypt(InputStream ciphertext, OutputStream plaintext) | |||
| while (packets.hasNext()) { | |||
| Object packet = packets.next(); | |||
|
|
|||
| if (log.isLoggable(Level.FINEST)) | |||
| log.finest("unpack " + packet.getClass()); | |||
| if (log.isTraceEnabled()) | |||
There was a problem hiding this comment.
It's not needed to check if log.isTraceEnabled() is true
|
Thanks for doing the work to convert to SLF4J, and creating a pull request for it! -- sorry I took so long to get it merged. I merged it in with this commit: 41f4b1d -- but managed to put the wrong PR number in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution of issue #6
changes in mapping of level JUL - SLF4j:
FINEST -> TRACE
FINER -> DEBUG
FINE -> DEBUG
INFO -> INFO
WARNING -> WARN
SEVERE -> ERROR
Adding {} placeholder
remove JUL imports