This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fix the scripting for table-valued parameters #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2018 14:32
The idempotency method was not scripting out properly when the object type is `TT` when the option is `if-not-exists`. This commit fixes that. fixes justinlettau#22
The comma after the last column is not allowed. It raises a syntax error. Exception: `Incorrect syntax near ')'. `
davidguilherme
force-pushed
the
fix-idempotency-tt
branch
from
d6be85e to
21f9f48
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes basically two bugs related to table-valued parameters.
pullcommand was not scripting thetable-valued parameterscorrectly when the idempotency option isif-not-exists;pullcommand was scripting the comma out after the last column which is not allowed.Checklist
Please ensure your pull request fulfills the following requirements:
Type
What kind of change does this pull request introduce?
Breaking Changes
Does this pull request introduce any breaking changes?
Other Information
fixes #22