You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
The table-valued parameters are not being created when the idempotency option for table-valued parameters is if-not-exists even though they are not already created.
Expected behavior
The command push should create the table-valued parameters when the idempotency option for this is if-not-exists and they are not already created.
Steps to Reproduce
Sets the idempotency option for table-valued parameter to if-not-exists.
Pull any database with table-valued parameters;
Push the scripts to an empty database;
Checks if there is the table-valued parameter in there.
The idempotency method was not scripting out properly when the object type is
`TT` when the option is `if-not-exists`. This commit fixes that.
fixesjustinlettau#22
* chore(pull): fix the idempotency method for table-valued parameters
The idempotency method was not scripting out properly when the object type is
`TT` when the option is `if-not-exists`. This commit fixes that.
fixes#22
* chore(pull): do not script comma out after the tvp's last column
The comma after the last column is not allowed. It raises a syntax
error. Exception: `Incorrect syntax near ')'. `
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Type
What kind of issue is this?
Current Behavior
The
table-valued parameters
are not being created when the idempotency option fortable-valued parameters
isif-not-exists
even though they are not already created.Expected behavior
The command
push
should create thetable-valued parameters
when the idempotency option for this isif-not-exists
and they are not already created.Steps to Reproduce
table-valued parameter
toif-not-exists
.Other Information
I believe this problem is related to this line: https://github.com/justinlettau/sql-source-control/blob/master/src/sql/script.ts#L76
I can open a Pull Request for this.
The text was updated successfully, but these errors were encountered: