Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

fix: port type should be number instead of string #118

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

Jaxelr
Copy link
Contributor

@Jaxelr Jaxelr commented Jul 11, 2020

Description

On ssc init, convert data type of port from string to number. This fixes issue #116

Checklist

Please ensure your pull request fulfills the following requirements:

  • The commit messages follow our guidelines (CONTRIBUTING.md).
  • Tests for any changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Type

What kind of change does this pull request introduce?

  • Bug.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other (please describe below).

Breaking Changes

Does this pull request introduce any breaking changes?

[ ] Yes
[X] No

Other Information

@justinlettau justinlettau merged commit 69e9b2b into justinlettau:master Jul 12, 2020
@Jaxelr Jaxelr deleted the issues/116 branch July 13, 2020 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants