Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

ssc init creates config with port as string #116

Closed
Jaxelr opened this issue Jul 8, 2020 · 1 comment
Closed

ssc init creates config with port as string #116

Jaxelr opened this issue Jul 8, 2020 · 1 comment

Comments

@Jaxelr
Copy link
Contributor

Jaxelr commented Jul 8, 2020

Describe the Issue

ssc init currently creates the Main configuration file using the datatype of string for the port. This causes an error when the ssc pull command is subsequently used

Expected behavior

ssc init and ssc pull should be consistent in the management of the configuration property of port

Steps to Reproduce

  1. ssc init
  2. server: localhost
  3. port: 1433
  4. database: master
  5. user: ssc
  6. password; password
  7. connection: dev

image

Heres the json generated:

{
  "connections": [
    {
      "database": "master",
      "name": "dev",
      "password": "password",
      "port": "1433",
      "server": "localhost",
      "user": "ssc"
    }
  ]
}

ssc pull dev

image

Other Information

When i change the ssc.json port to integer

image

@Jaxelr
Copy link
Contributor Author

Jaxelr commented Jul 15, 2020

Closing since PR got merged, Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant