Feat/python311 #89
Merged
Feat/python311 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- drop the use of _Accessor class from the internals of pathlib. It was removed in python 3.11 which broke... everything. - Detect python < 3.11 and provide the base needed accessor method "scandir" - Detect python >= 3.11 and provide the Path._scandir function - Move accessor methods to the Pathy class - Remove a few _accessor tests, and update those that referenced the accessor directly - TODO: Remove the use of pathlib scandir entirely, and replace it with an inlined glob matching system to provide this functionality. This is the only tech debt the project has left at this point that I can see.
- not sure why I'm getting _accessor is readonly errors. stack overflow suggests it might be this. use the working code from main branch
- file not fs 😅 - better detect s3 and gcs test capabilities
- the mypy version with a fix for numpy errors doesn't support the older python 3.6 builds
- the mypy build that works with 3.6 doesn't work with python 3.11 - the build that works with 3.10+ doesn't work with 3.6 since it's unpublished for that version.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #89 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 1030 1004 -26
=========================================
- Hits 1030 1004 -26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- instead of has_gcs or has_s3, add gcs_installed and gcs_testable where installed means the deps are there, and testable means the env vars are there to support it.
BREAKING CHANGE: Pathy.exists() no longer enumerates buckets if given a path with no root.
- Accidental removal
justindujardin
added a commit
that referenced
this pull request
Nov 15, 2022
I missed this bit while adding support for python 3.11 in #89
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
justindujardin
added a commit
that referenced
this pull request
Nov 15, 2022
I missed this bit while adding support for python 3.11 in #89 * chore: keep codecov from reporting early Builds look failed until all the tasks are done. Codecov's site says that `require_ci_to_pass` is default yes. 🤷 Add after_n_builds set to the number of build tasks we have.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
## [0.7.1](v0.7.0...v0.7.1) (2022-11-15) ### Bug Fixes * **pypi:** add classifiers for python 3.10 / 3.11 ([515cb5d](515cb5d)), closes [#89](#89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11 dropped the use of Accessor classes (🎉), but it broke Pathy.
This PR refactors away from the Accessor class to using BucketClients directly from the Pathy class. This change calls out the one bit of technical debt that the project has: its dependency on pathlib internals. Pathy relies explicitly on the base pathlib class to do glob matches against scandir results. This isn't great because the project breaks when internals change, but it keeps the library simple by not reimplementing wildcard matching functionality.
Changes:
Future Work