chore: fix caching issue for conditional merchant creation #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue with the consistency of nested types for caching, the issue lies in the way
Deref
works and how the traits are implemented.example:
In this scenerio struct of type
B
can be passed to the functionhandle
without any issue, but when trying to passA
you will get an error:This example describes the situation with caching, where as the intermediate layers are only implementing
Deref
for the internal Storage, and does not auto implement the traits that are implemented on Storage. This issue will be mitigated once rust stabalizesspecialization
.Tracking issue for
specialization
: rust-lang/rust#31844