Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Drop support for retro_logo #324

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Drop support for retro_logo #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,19 +109,6 @@ Support for existing JupyterLab themes!

![An animation of a user changing the Jupyter interface to use the dark theme.](https://user-images.githubusercontent.com/591645/101953333-75d9c180-3bfa-11eb-868f-af54d1ea7091.gif)

For an even more retro look, you might want to start `retrolab` with the `--retro-logo` CLI flag:

```bash
jupyter retro --retro-logo

# or
# jupyter retro --RetroApp.retro_logo=True
```

Example with the [JupyterLab Miami Nights Theme](https://github.com/timkpaine/jupyterlab_miami_nights) installed as a prebuilt extension:

![The Jupyter interface using the Miami Nights theme](https://user-images.githubusercontent.com/591645/119634905-77e3b580-be13-11eb-9c4c-d187ebea9df8.png)

### Zen Mode 😌

![An animation of a user using the command palette to enable Zen Mode in JupyterLab](https://user-images.githubusercontent.com/591645/101923740-149cf880-3bd0-11eb-9617-e3349a76d034.gif)
Expand Down
6 changes: 2 additions & 4 deletions packages/application-extension/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ import { ITranslator } from '@jupyterlab/translation';

import { RetroApp, RetroShell, IRetroShell } from '@retrolab/application';

import { jupyterIcon, retroInlineIcon } from '@retrolab/ui-components';
import { jupyterIcon } from '@retrolab/ui-components';

import { PromiseDelegate } from '@lumino/coreutils';

Expand Down Expand Up @@ -138,9 +138,7 @@ const logo: JupyterFrontEndPlugin<void> = {
node.rel = 'noopener noreferrer';
const logo = new Widget({ node });

const retroLogo = PageConfig.getOption('retroLogo') === 'true';
const icon = retroLogo ? retroInlineIcon : jupyterIcon;
icon.element({
jupyterIcon.element({
container: node,
elementPosition: 'center',
padding: '2px 2px 2px 8px',
Expand Down
11 changes: 0 additions & 11 deletions retrolab/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ def get_page_config(self):
"frontendUrl": ujoin(self.base_url, "retro/"),
"exposeAppInBrowser": app.expose_app_in_browser,
"collaborative": app.collaborative,
"retroLogo": app.retro_logo,
}

if 'hub_prefix' in app.serverapp.tornado_settings:
Expand Down Expand Up @@ -168,9 +167,6 @@ def get(self, path=None):


aliases = dict(base_aliases)
aliases.update({
"retro-logo": "RetroApp.retro_logo"
})


class RetroApp(NBClassicConfigShimMixin, LabServerApp):
Expand Down Expand Up @@ -200,9 +196,6 @@ class RetroApp(NBClassicConfigShimMixin, LabServerApp):
collaborative = Bool(
False, config=True, help="Whether to enable collaborative mode."
)
retro_logo = Bool(
False, config=True, help="Whether to use the RetroLab inline logo."
)

flags = flags
flags['expose-app-in-browser'] = (
Expand All @@ -213,10 +206,6 @@ class RetroApp(NBClassicConfigShimMixin, LabServerApp):
{"RetroApp": {"collaborative": True}},
"Whether to enable collaborative mode.",
)
flags["retro-logo"] = (
{"RetroApp": {"retro_logo": True}},
"Whether to use the RetroLab inline logo",
)

def initialize_handlers(self):
self.handlers.append(
Expand Down