Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

This pull request adds alt text to the retrolab readme #306

Closed
wants to merge 2 commits into from
Closed

This pull request adds alt text to the retrolab readme #306

wants to merge 2 commits into from

Conversation

tonyfast
Copy link
Contributor

This pull request is the outcome of our accessibility workshop. It adds alt to the current retrolab readme. Thanks to @isabela-pf @jweill-aws for all the work.

tonyfast and others added 2 commits December 16, 2021 07:38
@tonyfast
Update README.md
341c520
@tonyfast @JasonWeill
@gabalafou @jtpio @isabela-pf
add alt text together during the 2021 diy a11y workshop (#1)
a9fd893 
Co-authored-by: Tony Fast <[email protected]>
Co-authored-by: Jason Weill <[email protected]>
Co-authored-by: Gabriel Fouasnon <[email protected]>
Co-authored-by: Jeremy Tuloup <[email protected]>
Co-authored-by: Isabela Presedo-Floyd <[email protected]>
@welcome
Copy link

welcome bot commented Dec 17, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch deathbeds/retrolab/main

@jtpio jtpio added the documentation Improvements or additions to documentation label Dec 17, 2021
@jtpio jtpio added this to the 0.3.x milestone Dec 17, 2021
@jtpio
Copy link
Member

jtpio commented Dec 17, 2021

Thanks all!

jtpio
jtpio reviewed Dec 17, 2021
View reviewed changes
app/package.json
@@ -135,7 +135,7 @@
"glob": "~7.1.6",
"mini-css-extract-plugin": "~0.9.0",
"npm-run-all": "^4.1.5",
"playwright": "^1.12.3",
"playwright": "^1.17.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR might be bringing some additional changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i think i messed something up merging. ill have a look over the weekend. ill fix this soon.

@isabela-pf isabela-pf mentioned this pull request Dec 17, 2021
Open
@jtpio
Copy link
Member

jtpio commented Dec 24, 2021

@tonyfast I rebased this PR to only include the change to README.md.

However I'm not able to push to the fork repo, probably because the PR was opened from the main branch.

Here is the link to the diff if you would like to open a new PR with the single commit: https://github.com/jupyterlab/retrolab/compare/main...jtpio:readme-a11y?expand=1

Thanks!

@jtpio
Copy link
Member

jtpio commented Dec 27, 2021

Closing as fixed by #310.

@jtpio jtpio closed this Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.x
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyfast @jtpio