Merge pull request #324 from jtpio/drop-retro-logo

Drop support for `retro_logo`
jupyterlab · Jan 20, 2022 · 237c456 · 237c456
2 parents 3470287 + a4b7c83
commit 237c456
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 28 deletions.
diff --git a/README.md b/README.md
@@ -109,19 +109,6 @@ Support for existing JupyterLab themes!
 
 ![An animation of a user changing the Jupyter interface to use the dark theme.](https://user-images.githubusercontent.com/591645/101953333-75d9c180-3bfa-11eb-868f-af54d1ea7091.gif)
 
-For an even more retro look, you might want to start `retrolab` with the `--retro-logo` CLI flag:
-
-```bash
-jupyter retro --retro-logo
-
-# or
-# jupyter retro --RetroApp.retro_logo=True
-```
-
-Example with the [JupyterLab Miami Nights Theme](https://github.com/timkpaine/jupyterlab_miami_nights) installed as a prebuilt extension:
-
-![The Jupyter interface using the Miami Nights theme](https://user-images.githubusercontent.com/591645/119634905-77e3b580-be13-11eb-9c4c-d187ebea9df8.png)
-
 ### Zen Mode 😌
 
 ![An animation of a user using the command palette to enable Zen Mode in JupyterLab](https://user-images.githubusercontent.com/591645/101923740-149cf880-3bd0-11eb-9617-e3349a76d034.gif)

diff --git a/packages/application-extension/src/index.ts b/packages/application-extension/src/index.ts
@@ -33,7 +33,7 @@ import { ITranslator } from '@jupyterlab/translation';
 
 import { RetroApp, RetroShell, IRetroShell } from '@retrolab/application';
 
-import { jupyterIcon, retroInlineIcon } from '@retrolab/ui-components';
+import { jupyterIcon } from '@retrolab/ui-components';
 
 import { PromiseDelegate } from '@lumino/coreutils';
 
@@ -138,9 +138,7 @@ const logo: JupyterFrontEndPlugin<void> = {
     node.rel = 'noopener noreferrer';
     const logo = new Widget({ node });
 
-    const retroLogo = PageConfig.getOption('retroLogo') === 'true';
-    const icon = retroLogo ? retroInlineIcon : jupyterIcon;
-    icon.element({
+    jupyterIcon.element({
       container: node,
       elementPosition: 'center',
       padding: '2px 2px 2px 8px',

diff --git a/retrolab/app.py b/retrolab/app.py
@@ -41,7 +41,6 @@ def get_page_config(self):
             "frontendUrl": ujoin(self.base_url, "retro/"),
             "exposeAppInBrowser": app.expose_app_in_browser,
             "collaborative": app.collaborative,
-            "retroLogo": app.retro_logo,
         }
 
         if 'hub_prefix' in app.serverapp.tornado_settings:
@@ -168,9 +167,6 @@ def get(self, path=None):
 
 
 aliases = dict(base_aliases)
-aliases.update({
-   "retro-logo": "RetroApp.retro_logo"
-})
 
 
 class RetroApp(NBClassicConfigShimMixin, LabServerApp):
@@ -200,9 +196,6 @@ class RetroApp(NBClassicConfigShimMixin, LabServerApp):
     collaborative = Bool(
         False, config=True, help="Whether to enable collaborative mode."
     )
-    retro_logo = Bool(
-        False, config=True, help="Whether to use the RetroLab inline logo."
-    )
 
     flags = flags
     flags['expose-app-in-browser'] = (
@@ -213,10 +206,6 @@ class RetroApp(NBClassicConfigShimMixin, LabServerApp):
         {"RetroApp": {"collaborative": True}},
         "Whether to enable collaborative mode.",
     )
-    flags["retro-logo"] = (
-        {"RetroApp": {"retro_logo": True}},
-        "Whether to use the RetroLab inline logo",
-    )
 
     def initialize_handlers(self):
         self.handlers.append(