Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try and handle deps on Windows #229

Merged
merged 8 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/actions/base-setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,14 @@ runs:
elif [ $DEPENDENCY_TYPE == 'minimum' ]; then
FLAGS="--resolution=lowest-direct"
fi
if [ "$RUNNER_OS" == "Windows" ]; then
if [ -n "$FLAGS" ]; then
echo "dependency_type not supported on Windows"
exit 1
else
exit 0
fi
fi
if [ -f pyproject.toml ]; then
uv pip compile $FLAGS pyproject.toml -o $HOME/constraints.txt
echo "PIP_CONSTRAINT=$HOME/constraints.txt" >> $GITHUB_ENV
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ environment variable, so that installations will use that file.
By default the Python version will be "3.7", which can be overridden with
`python_version`. Note that the environment variable also works if
you use virtual environments like `hatch`.
Note: this does not work on Windows, and will error.

```yaml
minimum_version:
Expand All @@ -68,12 +69,13 @@ you use virtual environments like `hatch`.
run: pytest
```

If you want to use your minimum dependencies, you can use the following
If you want to use your pending dependencies, you can use the following
option, which will create a constraints file and set the `PIP_CONSTRAINT`
environment variable, so that installations will use that file.
By default the Python version will be "3.12", which can be overridden with
`python_version`. Note that the environment variable also works if
you use virtual environments like `hatch`.
Note: this does not work on Windows, and will error.

```yaml
prereleases:
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@jupyterlab/maintainer-tools",
"version": "0.25.2",
"private": true
"name": "@jupyterlab/maintainer-tools",
"version": "0.25.2",
"private": true
}
Loading