Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix columnCount signature #82

Merged
merged 1 commit into from
Jun 25, 2020
Merged

fix columnCount signature #82

merged 1 commit into from
Jun 25, 2020

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Jun 24, 2020

fixes the type of region in columnCount method

afshin
afshin approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Well spotted.

👍

@blink1073
Copy link
Contributor

Thanks @mbektasbbg!

@blink1073 blink1073 merged commit 39cf66d into jupyterlab:master Jun 25, 2020
@blink1073
Copy link
Contributor

https://github.com/jupyterlab/lumino/blob/master/CHANGELOG.md#2020-06-24

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mbektas @blink1073 @afshin