Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Chrome default scroll on focus #190

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

ibdafna
Copy link
Member

@ibdafna ibdafna commented Jun 9, 2021

This PR fixes an issue where Chrome automatically scrolls to the center of an element when the .focus() method is triggered on a Node element. This behaviour results in context menus being rendered out of position when they are opened on an element which is not focused.

For reference: https://www.chromestatus.com/feature/5745122025144320

Signed-off-by: Itay Dafna [email protected]

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@blink1073 blink1073 merged commit 2afa2e7 into jupyterlab:master Jun 10, 2021
@blink1073 blink1073 added the bug Something isn't working label Jun 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants