Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve note about performance of commandExecuted handlers. #127

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Improve note about performance of commandExecuted handlers. #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/commands/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ class CommandRegistry {
* A signal emitted when a command has executed.
*
* #### Notes
* Care should be taken when consuming this signal. It is intended to
* be used largely for debugging and logging purposes. It should not
* be (ab)used for general purpose spying on command execution.
* Care should be taken when consuming this signal. The command system is used
* by many components for many user actions. Handlers registered with this
* signal must return quickly to ensure the overall application remains responsive.
*/
get commandExecuted(): ISignal<this, CommandRegistry.ICommandExecutedArgs> {
return this._commandExecuted;
Expand Down