-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Storybook #11649
Remove Storybook #11649
Conversation
Thanks for making a pull request to jupyterlab! |
cc @telamonian if you have any input on this |
Thanks for starting this. We spoke briefly about that in #11173 (comment) @jasongrout and I. The agreement was indeed to drop it as no active developers use it (this is probably the reason it was never updated 😉). |
Marking as ready as I'm not planning to make any more changes. We can also leave it open for a bit so folks have time to comment. This can also be discussed at the next weekly meeting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jtpio
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. The mean relative comparison is computed with 95% confidence. Results table
Changes are computed with expected as reference. |
Sorry I closed it a bit too quickly. I will raise the point at today's team meeting. And revert if needed. |
References
In #11648 we noticed some dependencies like
nth-check
are difficult to update and come from the dependency onstorybook
.Storybook seems to be coming back often when we try to update dependencies, for example:
url-parse~1.5.4
#10755I'm not sure if anyone is currently using it? Which is why this PR proposes we just remove it. If someone is still using, then we should consider keeping it.
Code changes
User-facing changes
None
Backwards-incompatible changes
Should be none.