Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit graph visualization on history sidebar #1156

Merged
merged 31 commits into from
Aug 19, 2022

Conversation

BoscoCHW
Copy link
Contributor

@BoscoCHW BoscoCHW commented Jul 29, 2022

Displayed commit graph on history sidebar that is responsive to commit history expansion

Fixes #1109

Issues:
Codes are currently very messy. Will have to clean up code after the functionality is finished.
The graph became unresponsive to history expansion after changing repo / path. Somehow the useEffect function was not run after navigating to another repo, but if you switch to the "change" panel and switch back to the "history" panel, it works as expected.

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch BoscoCHW/jupyterlab-git/issue-1109

@BoscoCHW BoscoCHW marked this pull request as ready for review August 8, 2022 21:00
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great.

I added a couple of suggestion and I noticed that the package-lock.json file slipped in. Would you mind removing it?

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks @BoscoCHW and @iflinda for this one

@fcollonval fcollonval merged commit 079e15b into jupyterlab:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support branch visualization similar to git log --graph
3 participants