plotly-extension: Accept config object in data #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this @gnestor. Have you confirmed that this is backward compatible with versions of plotly.py that don't provide |
|
Yes, I just tested this against plotly.py@master and it works as expected. This doesn't break any backwards compatibility because it simply passes along the config object from plotly.py to plotly.js. |
|
@jonmmease Just published @jupyterlab/plotly-extension 0.18.1 👍 |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to plotly/plotly.py#1281
This just accept a config object for plotly.js that can be passed by plotly.py or the user.
Demo notebook: https://gist.github.com/gnestor/07f30edf28a8c3a88a01dfc748a8201a