Remove the unused ISettingRegistry token from the file browser plugin
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Thanks @jtpio, could you trigger the release action? The current version is broken |
|
I'm doing it. |
|
Done. |
|
In an unlikely circumstance if anyone else finds them bitten by this - the error on the server side would be: because the Thanks for the quick fix! Should we add a snapshot test for filebrowser showing up? |
andrii-i
pushed a commit
to andrii-i/jupyter-collaboration
that referenced
this pull request
Feb 11, 2025
…in (jupyterlab#356) * Remove unused `ISettingRegistry` token * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.0.0b5 is broken due to this token.