Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Enhancement Proposal(JEP) document #1

Merged
merged 4 commits into from
Jun 14, 2019

Conversation

jaipreet-s
Copy link
Collaborator

Hi all,

In the interest of working backwards from the JEP process, I've started the final JEP proposal documentation. This encapsulates the design and discussions done here and offline.

I've attempted to layout the components of the telemetry system and each of their sub-components

A few sections are TBD and still work-in-progress. I am hoping someone who is more familiar with JupyterHub can pick up the that section.

(This is a carry-over from jupyterlab/jupyterlab-telemetry#4)

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaipreet-s This is awesome. Thank you for putting this JEP together. I'm really happy with it.

I've left some comments inline.

JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
@Zsailer
Copy link
Member

Zsailer commented Jun 10, 2019

One big design decision I'd like to discuss is: should telemetry be a jupyter server extension or core jupyter "service"?

Jupyter "services" are REST APIs that are native to jupyter_server. Every running jupyter server promises to expose all services' endpoints.

Server Extensions are loaded dynamically after server initialization. They exist separately from the server, and the server must be configured to expose their endpoints.

Should we require that every jupyter_server expose the telemetry endpoints?

JEP.md Show resolved Hide resolved
@yuvipanda
Copy link
Collaborator

Thanks for getting this going, @jaipreet-s. I've left some comments, will do another round soon.

I'm trying to understand the relationship between:

  1. This repo and jupyterlab/jupyterlab-telemetry
  2. This document and https://github.com/jupyterlab/jupyterlab-telemetry/blob/master/design.md

What are your thoughts on this?

JEP.md Show resolved Hide resolved
JEP.md Show resolved Hide resolved
@Zsailer
Copy link
Member

Zsailer commented Jun 13, 2019

I'm thinking we should merge this and open PRs to iterate?

@jaipreet-s
Copy link
Collaborator Author

jaipreet-s commented Jun 13, 2019

I'm thinking we should merge this and open PRs to iterate?

I'm going to respond/incorporate the comments soon and then we can merge and iterate. There's some TBD sections , especially for JHub. (I've been occupied these past few days)

@Zsailer
Copy link
Member

Zsailer commented Jun 13, 2019

Great. Let me know when you're ready.

There's some TBD sections, especially for JHub

Yeah, I think we can fill those sections in separate PRs.

@jaipreet-s
Copy link
Collaborator Author

Thanks for getting this going, @jaipreet-s. I've left some comments, will do another round soon.

I'm trying to understand the relationship between:

1. This repo and jupyterlab/jupyterlab-telemetry

2. This document and https://github.com/jupyterlab/jupyterlab-telemetry/blob/master/design.md

What are your thoughts on this?

  1. This was a new repo created to contain the Jupyter telemetry system parts that are not specific to any component like JupyterLab. I didn't create it but looks like this is where most of the stuff will reside.
  2. This is the formal proposal for the Jupyter Enhancement Proposal format. I've definitely used bits from that doc ;-) and added more stuff around concrete design recommentations for components lik JupyterLab. We should get this doc to a state where we feel comfortable publishing as a JEP

@jaipreet-s
Copy link
Collaborator Author

jaipreet-s commented Jun 14, 2019

@Zsailer @yuvipanda

I've incorporated most feedback and also added y'all as authors. This is ready to merge from my perspective.

Can someone volunteer to fill out the JHub section?

@jaipreet-s
Copy link
Collaborator Author

One big design decision I'd like to discuss is: should telemetry be a jupyter server extension or core jupyter "service"?

Jupyter "services" are REST APIs that are native to jupyter_server. Every running jupyter server promises to expose all services' endpoints.

Server Extensions are loaded dynamically after server initialization. They exist separately from the server, and the server must be configured to expose their endpoints.

Should we require that every jupyter_server expose the telemetry endpoints?

We'll likely have to support the Jupyter Notebook (Classic) server since the jupyter_server is very new , so a server extension helps in that way. Thoughts?

@yuvipanda yuvipanda merged commit 76232d6 into jupyter:master Jun 14, 2019
@yuvipanda
Copy link
Collaborator

Thanks, @jaipreet-s! Let's merge this and collaborate in PRs.

I'll fill out the hub section!

@jaipreet-s jaipreet-s deleted the jep branch June 14, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants