-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter Enhancement Proposal(JEP) document #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaipreet-s This is awesome. Thank you for putting this JEP together. I'm really happy with it.
I've left some comments inline.
One big design decision I'd like to discuss is: should telemetry be a jupyter server extension or core jupyter "service"? Jupyter "services" are REST APIs that are native to jupyter_server. Every running jupyter server promises to expose all services' endpoints. Server Extensions are loaded dynamically after server initialization. They exist separately from the server, and the server must be configured to expose their endpoints. Should we require that every jupyter_server expose the telemetry endpoints? |
Thanks for getting this going, @jaipreet-s. I've left some comments, will do another round soon. I'm trying to understand the relationship between:
What are your thoughts on this? |
I'm thinking we should merge this and open PRs to iterate? |
I'm going to respond/incorporate the comments soon and then we can merge and iterate. There's some TBD sections , especially for JHub. (I've been occupied these past few days) |
Great. Let me know when you're ready.
Yeah, I think we can fill those sections in separate PRs. |
|
I've incorporated most feedback and also added y'all as authors. This is ready to merge from my perspective. Can someone volunteer to fill out the JHub section? |
We'll likely have to support the Jupyter Notebook (Classic) server since the jupyter_server is very new , so a server extension helps in that way. Thoughts? |
Thanks, @jaipreet-s! Let's merge this and collaborate in PRs. I'll fill out the hub section! |
Hi all,
In the interest of working backwards from the JEP process, I've started the final JEP proposal documentation. This encapsulates the design and discussions done here and offline.
I've attempted to layout the components of the telemetry system and each of their sub-components
A few sections are TBD and still work-in-progress. I am hoping someone who is more familiar with JupyterHub can pick up the that section.
(This is a carry-over from jupyterlab/jupyterlab-telemetry#4)