Fix default value method for allow_remote_access when ip is '*'
#4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnestor
approved these changes
Nov 5, 2018
|
I can confirm that this fixes #3946 and it seems like a decent solution to me. @takluyver Care to merge? |
|
is this fix in 5.7.4? I'm seeing #3946 with 5.7.4 on Linux at the moment. |
|
@michaelaye doesn't look like it is - all releases from 5.7.0 - 5.7.4 all say "120 commits to master since this tag" - looks like those releases are mostly backports. This PR is still only in master. |
This was referenced Jan 25, 2019
|
@takluyver - is there an ETA for 5.8? If still unknown or weeks away, this seems like a good candidate for a 5.7.5 tag due to recent occurrences. |
|
@takluyver I can prep a new release. Are you waiting on anything? |
|
@gnestor Is there any update on the 5.8 ETA or getting this into a 5.7.x release? |
|
@takluyver @minrk Are we waiting on anything in particular to make a new release? |
This was referenced Sep 24, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3946. When the config value for
ipis set to*, meaning listen on all interfaces, it causes the default value method for theallow_remote_accessconfig option to fail. This PR adds a short circuit for that default value method.I didn't see an obvious place to put a new test, but on my local machine, this actually fixes a currently failing one.