Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue for val in stdout or stderr with _ (_ not always correctly displayed) #3193

Closed
Naereen opened this issue Jan 9, 2018 · 6 comments

Comments

@Naereen
Copy link
Contributor

Naereen commented Jan 9, 2018

Hi! 🎉 Merry new year!

Issue

Here is an example of a weird display issue:
bug_display_out_value_with_underscore_in_its_name
(The variable ex1_1 but displayed ex1 1. On Firefox 57, Ubuntu 17.10)

Another example, showing the difference between stdout and stderr output:
bug_display_out_value_with_underscore

Reason

It's a bug probably coming from the style in outputarea.less:96.

It can be fix by forcing a padding-bottom: 1px; rule for div.output_area pre:
bug_display_out_value_with_underscore_in_its_name2

I will submit the PR to fix this.

@takluyver
Copy link
Member

Thanks for the investigation! @gnestor do you think the fix is OK to slip into 5.3?

@Naereen
Copy link
Contributor Author

Naereen commented Jan 9, 2018

@takluyver Thanks for your quick feedback.

@gnestor
Copy link
Contributor

gnestor commented Jan 9, 2018

I don't see why not! Thanks @Naereen!

@Naereen
Copy link
Contributor Author

Naereen commented Jan 26, 2018

This was merged right (#3194), so I close this issue.

@Naereen Naereen closed this as completed Jan 26, 2018
@takluyver
Copy link
Member

Thanks :-)

For future reference, you can put Closes #3194 in the commit message, and then merging the PR will automatically close the issue.

@Naereen
Copy link
Contributor Author

Naereen commented Jan 26, 2018

I use this for personal projects, but I didn't know that it would work when the PR is merged, thanks!

@minrk minrk added this to the 5.4 milestone Jun 15, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants