Merge pull request #4674 from asreimer/patch-1

bugfix: shutdown_server returns True when pid exists
jupyter · Jun 25, 2019 · 3c9cad6 · 3c9cad6
2 parents 2d27429 + dd0f5d2
commit 3c9cad6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/notebook/notebookapp.py b/notebook/notebookapp.py
@@ -421,7 +421,7 @@ def shutdown_server(server_info, timeout=5, log=None):
 
     # Poll to see if it shut down.
     for _ in range(timeout*10):
-        if check_pid(pid):
+        if not check_pid(pid):
             if log: log.debug("Server PID %s is gone", pid)
             return True
         time.sleep(0.1)
@@ -434,7 +434,7 @@ def shutdown_server(server_info, timeout=5, log=None):
 
     # Poll to see if it shut down.
     for _ in range(timeout * 10):
-        if check_pid(pid):
+        if not check_pid(pid):
             if log: log.debug("Server PID %s is gone", pid)
             return True
         time.sleep(0.1)