Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTD: make sure nodejs is present #698

Merged
merged 1 commit into from
Sep 28, 2023
Merged

RTD: make sure nodejs is present #698

merged 1 commit into from
Sep 28, 2023

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 28, 2023

and build with Python 3.11

builds are failing with missing npm.

@minrk
RTD: make sure nodes is present
65051b9 
and build with Python 3.11
@minrk minrk added the maintenance Maintenance action on the project label Sep 28, 2023
@fcollonval
Copy link
Collaborator

Superseeds #697

fcollonval
fcollonval approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minrk

@fcollonval fcollonval merged commit e8ce18b into jupyter:master Sep 28, 2023
@fcollonval fcollonval mentioned this pull request Sep 28, 2023
Closed
@minrk minrk changed the title RTD: make sure nodes is present RTD: make sure nodejs is present Sep 28, 2023
@minrk minrk deleted the rtd branch September 28, 2023 13:07
@minrk minrk mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance action on the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minrk @fcollonval