Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support merge view with 3 panels (theirs | final | ours) in addition to the current 4 panels views #682

Closed
Tracked by #680
fcollonval opened this issue Sep 18, 2023 · 0 comments · Fixed by #705
Closed
Tracked by #680
Assignees

Comments

@fcollonval
Copy link
Collaborator

fcollonval commented Sep 18, 2023

In @jupyterlab/git, the merge addon from CM5 was used directly to display merge views for plain text using a 3 panels view: theirs | final | ours. It will be nice to add a setting in nbdime widget to select either the current 4 panels view or that 3 panel view.

@fcollonval fcollonval self-assigned this Sep 27, 2023
fcollonval added a commit to fcollonval/nbdime that referenced this issue Sep 28, 2023
fcollonval added a commit to fcollonval/nbdime that referenced this issue Sep 29, 2023
fcollonval added a commit to fcollonval/nbdime that referenced this issue Oct 3, 2023
fcollonval added a commit to fcollonval/nbdime that referenced this issue Oct 10, 2023
fcollonval added a commit that referenced this issue Oct 10, 2023
* Add ability to set showBase from CLI option

* Use DiffPanel for diff widgets

* Support merge view with 3 panels (theirs | final | ours) in addition to the current 4 panels views
Fixes #682

* Add integration tests

* Fix diff views

* Lint the code

* Fix final padding for merged editor in 3-panels view

* Fix scroll synchronization for 3-panels view

* Update Playwright Snapshots

* Update Playwright Snapshots

* Add delay to improve test robustness on Windows

* Change expectation

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant