Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_cell_marker_format yields incorrect styles #626

Closed
mlucool opened this issue Aug 26, 2022 · 2 comments · Fixed by #648
Closed

_cell_marker_format yields incorrect styles #626

mlucool opened this issue Aug 26, 2022 · 2 comments · Fixed by #648

Comments

@mlucool
Copy link
Contributor

mlucool commented Aug 26, 2022

return '<span style="color:red">**{0}**</span>'.format(text)
leads to incorrect styling (not bolded as intended) for <<<<<<< local I believe this is because of the following open tag <. It seems like we should instead use <b> tag.

image

As a note ======= does not look bold because the bolded version seems to just different placed. In the following image, the right pair is "bolded":
image

Should we instead set a font size? This is 1.5em, not bold (style="color:red; font-size: 1.5em"):
image

OS: Windows
Browser: Chrome 104
JupyterLab: 3.4.3

@mlucool
Copy link
Contributor Author

mlucool commented Nov 21, 2022

CC @vidartf in case you have any thoughts before I make a PR

@vidartf
Copy link
Collaborator

vidartf commented Nov 24, 2022

@mlucool It used to work well (#347) but I guess something changed in the markdown renderer? Using <b> is probably the best option, yes. I was wondering to myself if there was some good reason why ** was used rather than <b> in the first place, but I can't remember/think of anything, and can't find anything in git history, so please go ahead! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants