Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdime mergetool and nbmerge-web failing, nbmerge ok #550

Closed
shenberg opened this issue Nov 3, 2020 · 10 comments
Closed

nbdime mergetool and nbmerge-web failing, nbmerge ok #550

shenberg opened this issue Nov 3, 2020 · 10 comments

Comments

@shenberg
Copy link

shenberg commented Nov 3, 2020

Hiya, thanks for the amazing tool you've made here, even with the issue it's been a massive enabler and time-saver (I managed to work around the issue but it's there).

I'm running nbdime 2.1.0 on homebrew python 3.8.5 on MacOS 10.15.7. and I enabled the git integration globally.

I tried to run the mergetool on a conflicted merge of a notebook, and the browser stayed loading forever. Upon opening the browser's dev-tools, I saw an exception saying Uncaught (in promise) Error: Invalid merge decision, cannot have null base for deleted cell:

This is the same error as is seen in another issue that seems to have been resolved.

I thought the issue may be related to the fact that I'm looking at the merge after-the-fact, so I did as follows:

$ git show HEAD:notebook.ipynb >notebook.head.ipynb
$ git show branch-to-merge:notebook.ipynb >notebook.branch.ipynb
$ git show $(git merge-base HEAD branch-to-merge):notebook.ipynb  >notebook.base.ipynb
$ nbmerge-web notebook.base.ipynb notebook.head.ipynb notebook.branch.ipynb

and I got the same error, so no luck here.

To work around the issue, I ran nbmerge notebook.base.ipynb notebook.head.ipynb notebook.branch.ipynb >notebook.merge.ipynb (note no -web) and manually fixed the merge issues using the regular Jupyter UI.

Is there a way to let me use the fancy web UI next time I'm merging?

@vidartf
Copy link
Collaborator

vidartf commented Nov 10, 2020

Thanks for the report, and the kind words :)

This will be a lot faster for me to debug and fix if you can share the notebooks (maybe a cleaned up version if the notebooks are not for public sharing in their current form). If that is not possible, the second best thing could be to run the nbmerge command you shared with --decisions flag, and share the (cleaned up) output of that.

@shenberg
Copy link
Author

Will do. It contains a bunch of data I can't share, I'll clean it up and post it in a bit.

@jucor
Copy link

jucor commented May 11, 2021

@shenberg Any luck on this, please? That'd be very helpful :)

@vidartf
Copy link
Collaborator

vidartf commented May 12, 2021

@jucor If you are also having this problem, then you can help by sharing a set of notebooks that replicate the issue.

@jucor
Copy link

jucor commented May 12, 2021 via email

@vidartf
Copy link
Collaborator

vidartf commented May 17, 2021

My email should be in the commit log.

@jucor
Copy link

jucor commented Sep 19, 2021 via email

@moziada
Copy link

moziada commented Dec 21, 2022

Got the same case with the exception Uncaught (in promise) Error: Currently not able to handle decisions on variable "id" within browser's dev-tools, any luck yet resolving the issue?

@vidartf
Copy link
Collaborator

vidartf commented Nov 1, 2023

Closing this with the ID issue tracked in #690.

@vidartf vidartf closed this as completed Nov 1, 2023
@vidartf
Copy link
Collaborator

vidartf commented Nov 1, 2023

(if somebody else is experiencing this issue, please comment here or open another issue, ideally with some notebooks to reproduce the issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants