Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated export_by_name #945

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

WrRan
Copy link
Contributor

@WrRan WrRan commented Jan 26, 2019

Through exporter_locator was deprecated since nbconvert 5.0,

warnings.warn("""`nbconvert.exporters.exporter_locator` is deprecated in favor of `nbconvert.exporters.base` since nbconvert 5.0.""",
DeprecationWarning)

there still exists an import from it:
from .exporter_locator import export_by_name

This PR trys to fix it. :)

@takluyver
Copy link
Member

I'm OK with this. The semantic versioning scheme would say you can only remove things in a major release (like 6.0), but I think it's reasonable to allow rolling removals with a suitable deprecation period. It's been 2 years since 5.0 was released.

@MSeal
Copy link
Contributor

MSeal commented Feb 5, 2019

That seems reasonable to me. I was planning on shipping the 5.4.1 release -- should we merge this after or before the patch release you think @takluyver ?

@takluyver
Copy link
Member

I wouldn't remove something in a patch release - leave it for 5.5.

@MSeal MSeal added this to the 5.5 milestone Feb 8, 2019
@MSeal MSeal merged commit 67a199f into jupyter:master Feb 8, 2019
@MSeal
Copy link
Contributor

MSeal commented Feb 8, 2019

Sounds like we'll need to make some parallel fixes in the notebook server before 5.5 can release with this change fyi :)

Chilipp added a commit to Chilipp/sphinx-nbexamples that referenced this pull request May 7, 2019
since it has been removed in jupyter/nbconvert#945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants