Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move onlyif_cmds_exist decorator to test-specific utils #854

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Aug 7, 2018

Fixes #853

cc @Carreau @minrk

Copy link
Member

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Carreau Carreau requested a review from mpacer August 7, 2018 22:49
@SylvainCorlay
Copy link
Member Author

@Carreau that one is very mechanical and makes the master branch usable without pytest.

@Carreau
Copy link
Member

Carreau commented Aug 9, 2018 via email

@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Aug 9, 2018

That still move fonction import. So may be breaking API

This is moving something that was introduced after the last release.

@Carreau
Copy link
Member

Carreau commented Aug 9, 2018

This is moving something that was introduced after the last release.

Ok, that was one of the things I was going to check.

Merging then.

@Carreau Carreau merged commit 9f5c402 into jupyter:master Aug 9, 2018
@SylvainCorlay SylvainCorlay deleted the pytest-deps branch August 10, 2018 08:07
@mpacer mpacer added this to the 5.4 milestone Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants