Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring up to date with nbsphinx's compatibility with sphinx 1.5.1 #494

Closed
wants to merge 1 commit into from

Conversation

mpacer
Copy link
Member

@mpacer mpacer commented Dec 19, 2016

Same as #493, but for 5.x not master.

#492 (comment) points out that we can update to the latest sphinx so long as we update to the latest nbsphinx.

@takluyver
Copy link
Member

5.x doesn't currently have any commits that aren't on master. Our usual practice is to only make maintenance branches when we merge the first thing that won't be in the maintenance releases (i.e. for this branch, when we merge the first 6.0 only change). So I'm going to delete the 5.x branch for now to reduce the maintenance overhead.

@takluyver takluyver closed this Dec 20, 2016
@mpacer
Copy link
Member Author

mpacer commented Dec 21, 2016

This also was the branch to which our readthedocs pointed. And Matthias pointed out that it is bad to have it pointing to latest anyway since then it is liable to break. That was why I hadn't switched back to latest. This can be solved with a patch release that I'll release tomorrow.

Basically I want to get in the fix for in-memory representations of templates (#491), but that needs another pair of eyes, unless you think the tests look good as is.

@minrk minrk modified the milestone: no action Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants