Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure TEXINPUTS is an absolute path #2002

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Ensure TEXINPUTS is an absolute path #2002

merged 3 commits into from
Jun 10, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented Jun 8, 2023 •
edited
Loading

Fixes #2001. At the time of self.texinputs being set, we are still in the directory where nbconvert is called, so this fix should resolve correctly.

To-do: Add tests

@tuncbkose tuncbkose added the bug label Jun 8, 2023
@tuncbkose tuncbkose mentioned this pull request Jun 9, 2023
Merged
1 task
blink1073
blink1073 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) June 9, 2023 23:52
@blink1073 blink1073 merged commit 38dfebb into jupyter:main Jun 10, 2023
@tuncbkose tuncbkose deleted the texinputs branch June 12, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in TEXINPUTS
2 participants
@tuncbkose @blink1073