Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small update to docs hide cell #1567

Merged
merged 5 commits into from
May 13, 2021
Merged

small update to docs hide cell #1567

merged 5 commits into from
May 13, 2021

Conversation

lwasser
Copy link
Contributor

@lwasser lwasser commented May 12, 2021

closes #1194
In the documentation, the code to hide cells currently returns an error where it can't find the TagRemoveProcessor object. A resolution was proposed in this issue to register the processor prior to calling it.

Further the example is missing code to export the object to a file which many users may need to do! This pr simply fixes the code sample. @yuvipanda I'm very open to making any changes and testing the locally! I am running the most current released version of nbconvert. i built the docs locally and ran into a small issue:

(nbconvert) CIRES-EL-LM-020:docs leahwasser$ make html
sphinx-build -b html -d build/doctrees   source build/html
Running Sphinx v3.5.4
loading intersphinx inventory from https://docs.python.org/3.6/objects.inv...
loading intersphinx inventory from http://jinja.pocoo.org/docs/dev/objects.inv...
loading intersphinx inventory from https://nbformat.readthedocs.io/en/latest/objects.inv...
intersphinx inventory has moved: http://jinja.pocoo.org/docs/dev/objects.inv -> https://jinja.palletsprojects.com/en/master/objects.inv
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 22 source files that are out of date
updating environment: [new config] 22 added, 0 changed, 0 removed
reading sources... [ 86%] nbconvert_library                                            
Notebook error:
NoSuchKernel in nbconvert_library.ipynb:
No such kernel named python3

i'm not sure if that is related to my environment install but the docs that i modified should not actually cause any build issues. let's see what CI has to say.

UPDATE: i was able to fix this by installing notebook in my nbconvert dev envt and rerunning the notebook figuring perhaps it would then find the right kernel and add it to the notebook metadata. docs are now building nicely locally. i'll see if that URL fix also solves the CI issues.

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

CURRENTLY FAILING - but because of a bad url in nbconvert_library.ipynb - i believe the URL may be this instead so implemented that and will watch ci for happy green lights!
https://jakevdp.github.io/downloads/notebooks/XKCD_plots.ipynb

@lwasser lwasser marked this pull request as draft May 13, 2021 00:43
@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

It looks like circleci wants pip to be installed with the envt. i'm happy to add it. will let it build first and revisit.
Screen Shot 2021-05-12 at 6 48 20 PM

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

Huh - ok adding pip sped up t he build but now i'm getting this

`Warning, treated as error:
/root/checkout/nbconvert/exporters/exporter.py:docstring of nbconvert.exporters.exporter.Exporter.register_preprocessor:8:more than one target found for 'any' cross-reference 'Preprocessor': could be :py:class:`nbconvert.preprocessors.Preprocessor` or :py:class:`nbconvert.preprocessors.base.Preprocessor`

i see the docstring issue but am not sure which Preprocessor is correct. docs are building fine locally. happy to fix this too if i know which preprocessor to call there or how to fix this?

@lwasser lwasser marked this pull request as ready for review May 13, 2021 01:06
@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

ok @yuvipanda i may need your input on the docstring issue. it's unrelated to this PR but i'm happy to fix it if it's small with some direction. i'm also happy to undo the pip add. it just seemed to make circleci happier.

@yuvipanda
Copy link
Contributor

Ah that looks unrelated, @lwasser. Can you remove the pip related change, and I'll just merge?

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

@yuvipanda no problem! it's removed now!

@yuvipanda
Copy link
Contributor

Thanks, @lwasser. I'm digging through the test failures in #1569

@yuvipanda
Copy link
Contributor

@lwasser just noticed a small typo I think, sorry didn't catch this the first time around

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

@yuvipanda no worries - my mistake. typo is fixed. let me know what else you need! that pip install did seem to help CI out speedwise!

@yuvipanda yuvipanda merged commit 4856c69 into jupyter:master May 13, 2021
@yuvipanda
Copy link
Contributor

@lwasser \oo/ nah, this is good - I've merged it! Do you want to try another PR with the pip changes to see if we can unbreak the CI?

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

sure thing! i am in meetings for the next 1.5ish hours and can do it after! i think that docstring issue also needs to be addressed. it's only a warning but i think it's making CI unhappy. more in a bit!

@yuvipanda
Copy link
Contributor

@lwasser yep! I might head to bed anyway (still stuck in india), but will look when i wake up :)

@lwasser
Copy link
Contributor Author

lwasser commented May 13, 2021

oh gosh. are you unable to get a flight back @yuvipanda ? get some sleep!

@lwasser lwasser mentioned this pull request May 13, 2021
@yuvipanda
Copy link
Contributor

@lwasser yeah, long story, but i came here for 6 weeks in feb 2020 and here I am still...

@lwasser
Copy link
Contributor Author

lwasser commented May 18, 2021 via email

@yuvipanda
Copy link
Contributor

@lwasser yeah it's a total mess :( Hopefully I can come back before end of the year...

@MSeal MSeal added this to the 6.1 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting: No module named 'TagRemovePreprocessor'
3 participants