Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change webpdf display name #1515

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Change webpdf display name #1515

merged 1 commit into from
Feb 3, 2021

Conversation

yuvipanda
Copy link
Contributor

The name has been confusing folks a fair bit. LaTeX
is at least better known.

The name has been confusing folks a fair bit. LaTeX
is at least better known.
@yuvipanda
Copy link
Contributor Author

This shouldn't affect any commandline or API users.

@yuvipanda
Copy link
Contributor Author

An alternative is 'PDF via Chrome' - more accurate, and better brand recognition.

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the user feedback. I agree that this name is clearer

@MSeal
Copy link
Contributor

MSeal commented Feb 3, 2021

Probably means we should do a patch release in the near future -- I have not kept up with the repo over paternity leave though so I have little knowledge of current state of things

@MSeal MSeal merged commit 7ee8298 into jupyter:master Feb 3, 2021
@betatim
Copy link
Member

betatim commented Apr 10, 2021

What is the best way to deal with the fact that https://github.com/betatim/notebook-as-pdf uses the same text as display name? Will users get two entries in their menu and how can they tell the difference?

@MSeal MSeal added this to the 6.1 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants