Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include output of stdin stream in lab template #1454

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

atsuoishimoto
Copy link
Contributor

The lab template does not include stdin stream generated by input(). I propose to add new config exclude_output_stdin to exclude the stdin stream in lab template. The default value of exclude_output_stdin should be True for compatibility.

The CSS in this PR renders stdin stream as follows.

image

Copy link
Contributor

@MSeal MSeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this was missed when it was opened. The change looks good to me and I'll get this into the alpha release going out.

@MSeal MSeal merged commit 7533477 into jupyter:main Jun 7, 2021
@atsuoishimoto atsuoishimoto changed the title Include output of stdout stream in lab template Include output of stdin stream in lab template Jun 7, 2021
@atsuoishimoto
Copy link
Contributor Author

Thank you!

@MSeal MSeal added this to the 6.1 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants