Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docs on CircleCI #1114

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Create docs on CircleCI #1114

merged 3 commits into from
Oct 16, 2019

Conversation

mgeier
Copy link
Contributor

@mgeier mgeier commented Oct 14, 2019

These are the artifacts (created on my CircleCI project https://app.circleci.com/github/mgeier/nbconvert/pipelines):

https://22-49829768-gh.circle-artifacts.com/0/html/index.html
https://22-49829768-gh.circle-artifacts.com/0/nbconvert.pdf

Somebody will have to switch on CircleCI for this to work in this repo.

@mgeier
Copy link
Contributor Author

mgeier commented Oct 16, 2019

See #883.

@MSeal
Copy link
Contributor

MSeal commented Oct 16, 2019

Awesome, I'll get it merged and see if I can get it turned on (and a badge added).

@MSeal MSeal merged commit ea2cc90 into jupyter:master Oct 16, 2019
@mgeier mgeier deleted the circleci branch October 16, 2019 17:12
@MSeal
Copy link
Contributor

MSeal commented Oct 17, 2019

@mgeier #1116 shows the circle CI doc build against a PR. Also https://github.com/jupyter/nbconvert now has a circle CI badge for passing / failing status of master.

@MSeal MSeal added this to the 5.6.1 milestone Oct 21, 2019
@MSeal MSeal added this to the 5.6.1 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants