Allow HTML header anchor text to be HTML #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
commented
Sep 21, 2019
| @@ -44,10 +44,10 @@ | |||
|
|
|||
|
|
|||
| def wrap_text(text, width=100): | |||
| """ | |||
| """ | |||
There was a problem hiding this comment.
All these whitespace fixes were auto-made by my editor, I can try to revert them if it's noise
There was a problem hiding this comment.
All good imo. I do the same when touching files.
|
build error is on the parallel notebooks job, which I don't think is related to this... |
MSeal
approved these changes
Sep 21, 2019
| @@ -44,10 +44,10 @@ | |||
|
|
|||
|
|
|||
| def wrap_text(text, width=100): | |||
| """ | |||
| """ | |||
There was a problem hiding this comment.
All good imo. I do the same when touching files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many projects it's common for anchor links to be icons (e.g., SVGs) or images embedded with something like FontAwesome. I've tried to get this working with nbconvert, but it supplying HTML for the anchor link text (e.g.
<i class='far fa-link'></i>) gets sanitized into raw text instead of HTML.This PR does a quick check to see if the supplied anchor text is valid HTML and, if so, appends it to the link object with the assumption that it should be treated as HTML. This lets you do things like add fontawesome icons for anchor links.