Change RegExRemove to remove code cells with output #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the RegExRemovePreprocessor treated code cells without outputs specially: they were never removed, even if they matched the RegEx. This behavior was intentional but only documented in an internal method, check_conditions, not in the docs of an external method. See Issue jupyter#1091 for discussion. This commit removes that behavior and updates the documentation of check_conditions. It further removes the test that checked for this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
RegExRemovePreprocessortreated code cells without outputs specially: they were never removed, even if they matched the regex pattern. This behavior was intentional but only documented in an internal method,check_conditions, not in the docs of an external method. See Issue #1091 for discussion.This commit removes that behavior and updates the documentation of
check_conditions. It further removes the test that checked for this behavior.