Pip-install nbconvert on readthedocs.org #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I don't manage the doc builds much for nbconvert (and also don't use conda much) and it's not clear to me how to test this without merging to a branch or master. From what I can test I think this should work fine. I'm going to merge and check if the doc build has any issues and fix if it needs something more specific. Thanks for the improvement! |
|
Looks like the docs-build is still working so I think this change was good. |
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/nbconvert-5-6-0-release/1867/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1050 and tries to install
nbconvertviapipon https://readthedocs.org/.WARNING: I don't know if this actually works!
I'm using this method on several of my RTD projects, but I don't use
conda, so I don't know if that also works withconda.But if it does work, it seems cleaner than hacking
sys.path.