Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve the speed of valdiation (#1672)
Motivation: - We are looking to build out a notebook viewer with an eye toward performance. In our flamegraph research we found that as much as 90% of the time spent in Notebook creation can occur in the preprocessor valdiation logic. This pr introduces the optional idea of optimistic validation, in which we care not about which preprocessor introduces a validation error but that the notebook ends in a valid state, since we care more about speed. Related Issues: - #1663 Changes: - Introduces a config option to remove some of the validation checks. Questions: - I am new to the project and am not sure where a test should live for this logic, or the best way to structure such a test. If a reference is available I will happily added a test.
- Loading branch information