Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags and Aliases handling #1

Closed
echarles opened this issue Nov 16, 2019 · 2 comments
Closed

Flags and Aliases handling #1

echarles opened this issue Nov 16, 2019 · 2 comments

Comments

@echarles
Copy link
Member

echarles commented Nov 16, 2019 •
edited
Loading

In JupyterLab as jupyter_server extension, I import flags and aliases from nbclassic which fails on jupyter lab --watch with Unrecognized flag: '--watch'.

I replace those import from nbclassic with from jupyter_server.serverapp import aliases, flags and the lab can be started with the --watch flag. However, this Notebook flags are not taken into account.

See also jupyter-server/jupyter_server#140
@Zsailer Zsailer mentioned this issue Dec 2, 2019
Closed
@echarles
Copy link
Member Author

echarles commented Dec 5, 2019

This should be fixed with jupyter-server/jupyter_server#149 when merged.

@echarles
Copy link
Member Author

This is now fixed with jupyter-server/jupyter_server#159. Thx @Zsailer

RRosio added a commit to ericsnekbytes/nbclassic that referenced this issue Oct 18, 2022
@RRosio
testing full test suit runs jupyter#1
e225f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@echarles