This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Convey working directory of notebook #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When communicating with a Gateway that launches container-based kernels, it is desirable to mirror the notebook's working directory in cases where the container is sharing the notebook directory's volume. This is a common configuration in Jupyter Hub installations running on Kubernetes where the Notebook/Lab instance enables the mounting of the user's home directory and those same mounts are used via the Enterprise Gateway kernel images. This change adds `KERNEL_WORKING_DIR` to the json body of the kernel creation request which enables the receiving Gateway to potentially act on that value when launching kernel images.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When communicating with a Gateway that launches container-based kernels,
it is desirable to mirror the notebook's working directory in cases where
the container is sharing the notebook directory's volume. This is a
common configuration in Jupyter Hub installations running on Kubernetes
where the Notebook/Lab instance enables the mounting of the user's home
directory and those same mounts are used via the Enterprise Gateway
kernel images. This change adds
KERNEL_WORKING_DIRto the json bodyof the kernel creation request which enables the receiving Gateway to
potentially act on that value when launching kernel images.