Add Listeners API #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
reviewed
Aug 11, 2022
|
This is ready for a review 😎. This should be merged after #12 and will need to be rebased before merging. Otherwise, the main logic is in place. |
Zsailer
force-pushed
the
listener
branch
2 times, most recently
from
5d89bb9 to
3d78feb
Compare
afshin
reviewed
Aug 18, 2022
|
Thanks! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7
Add a simple API for "listening" to events and triggering a callback function when an event happens. The API is particularly useful for extension/plugin authors who might trigger extra logic when an event fires.
This could be achieved by adding a handler and routing it to some stream, then listening to that stream. But that is quite complicated for most usecases. Also, handlers are really reserved for consumers of the eventloggers parent application. This listeners API is meant to be used by extension authors looking to hook into events and extend them.
Todo: