Skip to content

Commit

Permalink
Add support for async kernel management via subclassing
Browse files Browse the repository at this point in the history
Introduced async subclasses that derive from synchronous classes,
overriding appropriate methods with async support.
  • Loading branch information
kevin-bates committed Mar 11, 2019
1 parent e813086 commit 9817e71
Show file tree
Hide file tree
Showing 8 changed files with 734 additions and 24 deletions.
4 changes: 2 additions & 2 deletions jupyter_client/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
from .connect import *
from .launcher import *
from .client import KernelClient
from .manager import KernelManager, run_kernel
from .manager import KernelManager, AsyncKernelManager, run_kernel
from .blocking import BlockingKernelClient
from .multikernelmanager import MultiKernelManager
from .multikernelmanager import MultiKernelManager, AsyncMultiKernelManager
4 changes: 2 additions & 2 deletions jupyter_client/ioloop/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
from .manager import IOLoopKernelManager
from .restarter import IOLoopKernelRestarter
from .manager import IOLoopKernelManager, AsyncIOLoopKernelManager
from .restarter import IOLoopKernelRestarter, AsyncIOLoopKernelRestarter
46 changes: 44 additions & 2 deletions jupyter_client/ioloop/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
Type,
)

from jupyter_client.manager import KernelManager
from .restarter import IOLoopKernelRestarter
from jupyter_client.manager import KernelManager, AsyncKernelManager
from .restarter import IOLoopKernelRestarter, AsyncIOLoopKernelRestarter


def as_zmqstream(f):
Expand All @@ -23,9 +23,11 @@ def wrapped(self, *args, **kwargs):
return ZMQStream(socket, self.loop)
return wrapped


class IOLoopKernelManager(KernelManager):

loop = Instance('tornado.ioloop.IOLoop')

def _loop_default(self):
return ioloop.IOLoop.current()

Expand Down Expand Up @@ -60,3 +62,43 @@ def stop_restarter(self):
connect_iopub = as_zmqstream(KernelManager.connect_iopub)
connect_stdin = as_zmqstream(KernelManager.connect_stdin)
connect_hb = as_zmqstream(KernelManager.connect_hb)


class AsyncIOLoopKernelManager(AsyncKernelManager):

loop = Instance('tornado.ioloop.IOLoop')

def _loop_default(self):
return ioloop.IOLoop.current()

restarter_class = Type(
default_value=AsyncIOLoopKernelRestarter,
klass=AsyncIOLoopKernelRestarter,
help=(
'Type of KernelRestarter to use. '
'Must be a subclass of IOLoopKernelRestarter.\n'
'Override this to customize how kernel restarts are managed.'
),
config=True,
)
_restarter = Instance('jupyter_client.ioloop.AsyncIOLoopKernelRestarter', allow_none=True)

def start_restarter(self):
if self.autorestart and self.has_kernel:
if self._restarter is None:
self._restarter = self.restarter_class(
kernel_manager=self, loop=self.loop,
parent=self, log=self.log
)
self._restarter.start()

def stop_restarter(self):
if self.autorestart:
if self._restarter is not None:
self._restarter.stop()
self._restarter = None

connect_shell = as_zmqstream(AsyncKernelManager.connect_shell)
connect_iopub = as_zmqstream(AsyncKernelManager.connect_iopub)
connect_stdin = as_zmqstream(AsyncKernelManager.connect_stdin)
connect_hb = as_zmqstream(AsyncKernelManager.connect_hb)
48 changes: 48 additions & 0 deletions jupyter_client/ioloop/restarter.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,20 @@
from __future__ import absolute_import
import warnings

from tornado import gen
from zmq.eventloop import ioloop

from jupyter_client.restarter import KernelRestarter
from traitlets import (
Instance,
)


class IOLoopKernelRestarter(KernelRestarter):
"""Monitor and autorestart a kernel."""

loop = Instance('tornado.ioloop.IOLoop')

def _loop_default(self):
warnings.warn("IOLoopKernelRestarter.loop is deprecated in jupyter-client 5.2",
DeprecationWarning, stacklevel=4,
Expand All @@ -42,3 +45,48 @@ def stop(self):
if self._pcallback is not None:
self._pcallback.stop()
self._pcallback = None


class AsyncIOLoopKernelRestarter(IOLoopKernelRestarter):

def start(self):
"""Start the polling of the kernel."""
if self._pcallback is None:
self._pcallback = ioloop.PeriodicCallback(
self.poll, 1000*self.time_to_dead,
)
self._pcallback.start()

@gen.coroutine
def poll(self):
if self.debug:
self.log.debug('Polling kernel...')
is_alive = yield gen.maybe_future(self.kernel_manager.is_alive())
if not is_alive:
if self._restarting:
self._restart_count += 1
else:
self._restart_count = 1

if self._restart_count >= self.restart_limit:
self.log.warning("AsyncIOLoopKernelRestarter: restart failed")
self._fire_callbacks('dead')
self._restarting = False
self._restart_count = 0
self.stop()
else:
newports = self.random_ports_until_alive and self._initial_startup
self.log.info('AsyncIOLoopKernelRestarter: restarting kernel (%i/%i), %s random ports',
self._restart_count,
self.restart_limit,
'new' if newports else 'keep'
)
self._fire_callbacks('restart')
yield self.kernel_manager.restart_kernel(now=True, newports=newports)
self._restarting = True
else:
if self._initial_startup:
self._initial_startup = False
if self._restarting:
self.log.debug("AsyncIOLoopKernelRestarter: restart apparently succeeded")
self._restarting = False
Loading

0 comments on commit 9817e71

Please sign in to comment.