Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubuntu-24.04 instead of ubuntu-latest #2210

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mathbunnyru
Copy link
Member

Describe your changes

Issue ticket if applicable

Checklist (especially for first-time contributors)

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests
  • I will try not to use force-push to make the review process easier for reviewers
  • I have updated the documentation for significant changes

@mathbunnyru
Copy link
Member Author

Why I want to use explicit tag:

  • consistent with aarch64 runners (there is no ubuntu-latest-arm-like tag at the moment)
  • we control when we switch, no bizarre situation when suddenly start building everything on new runners without even knowing about it
  • no warnings like https://github.com/jupyter/docker-stacks/actions/runs/12788007366 (having 67 warnings makes me to ignore them completely)
  • explicit is better than implicit

Downside:

  • need to make one more commit every 2 years :)

I don't think is gonna affect images in any way, but it's nice to be in control of how we build our images.

@mathbunnyru mathbunnyru merged commit 976ed6c into jupyter:main Feb 12, 2025
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant